Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-1180: Add test for changing language in mobile and desktop #1196

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

PB-1180: Add test for changing language in mobile and desktop #1196

wants to merge 3 commits into from
+115 −1

Conversation

ismailsunni
Copy link
Contributor

@ismailsunni ismailsunni commented Jan 14, 2025 •
edited by github-actions bot
Loading

@ismailsunni ismailsunni requested a review from pakb January 14, 2025 07:29
@ismailsunni ismailsunni requested review from ltkum and sommerfe January 14, 2025 07:29
@cypress Cypress
Copy link

cypress bot commented Jan 14, 2025 •
edited
Loading

web-mapviewer    Run #4414

Run Properties:  status check failed Failed #4414  •  git commit 7b8637e91f: PB-1180: Replace `then` with `should` for retryability.
Project web-mapviewer
Branch Review feat-pb-1180-test-lang-selection
Run status status check failed Failed #4414
Run duration 05m 49s
Commit git commit 7b8637e91f: PB-1180: Replace `then` with `should` for retryability.
Committer Ismail Sunni
View all properties for this run ↗︎
Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 21
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 233
View all changes introduced in this branch ↗︎

Tests for review

Failed  tests/cypress/tests-e2e/drawing.cy.js • 2 failed tests • e2e/electron/mobile

View Output

Test Artifacts
Drawing module tests > Drawing mode/tools > can create marker/icons and edit them Test Replay Screenshots
Drawing module tests > KML management > manages the KML layer correctly if it comes attached with an adminId at startup Test Replay Screenshots

pakb
pakb approved these changes Jan 20, 2025
View reviewed changes
tests/cypress/tests-e2e/changeLanguage.cy.js Outdated Show resolved Hide resolved
@ismailsunni ismailsunni force-pushed the feat-pb-1180-test-lang-selection branch from 7d8dd75 to ce5ed63 Compare February 3, 2025 07:18
@ismailsunni ismailsunni force-pushed the feat-pb-1180-test-lang-selection branch from ce5ed63 to 7b8637e Compare February 3, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakb pakb pakb approved these changes

@ltkum ltkum Awaiting requested review from ltkum

@sommerfe sommerfe Awaiting requested review from sommerfe

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ismailsunni @pakb