PB 1151: add warning message kml import partially out of bounds #1195
+98
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-PB-1151-add-warning-message-kml-import-partially-out-of-bounds
|
| Run status |
|
| Run duration | 04m 53s |
| Commit |
|
| Committer | Martin Künzi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
20
|
Skipped
|
0
|
Passing
|
231
|
| View all changes introduced in this branch ↗︎ | |
ltkum
force-pushed
the
feat-PB-1151-add-warning-message-kml-import-partially-out-of-bounds
branch
3 times, most recently
from
60bbd66 to
371f17c
Compare
pakb
reviewed
Jan 16, 2025
There was a problem hiding this comment.
I think I'd prefer that we add a list of warning message on each layer (like what we did with error messages), and that would streamline this kind of feedback.
I don't really like that we need a dedicated entry in the store for this specific, very edgy, use case
Issue : When a user import a file which is partially out of bounds, we want to notify the user that the file is not completely within bounds, and that some functionalities might not be available. Fix : we add a flag in the store, and the state of the flag will tell us if we need to show the warning message or the valid message.
ltkum
force-pushed
the
feat-PB-1151-add-warning-message-kml-import-partially-out-of-bounds
branch
from
371f17c to
6f16564
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : When a user import a file which is partially out of bounds, we want to notify the user that the file is not completely within bounds, and that some functionalities might not be available.
Fix : we add a flag in the store, and the state of the flag will tell us if we need to show the warning message or the valid message.
Test link