SUP-17558: Fix the abandoned binary data, caused by the unstable natu… #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re of BulkActionContext
plyhun
commented
Jan 15, 2025
common/src/main/java/com/gentics/mesh/context/impl/BulkActionContextImpl.java
Show resolved
Hide resolved
plyhun
commented
Jan 15, 2025
core/src/main/java/com/gentics/mesh/core/actions/impl/BranchDAOActionsImpl.java
Show resolved
Hide resolved
plyhun
commented
Jan 15, 2025
.../src/main/java/com/gentics/mesh/core/endpoint/admin/consistency/UploadsConsistencyCheck.java
Show resolved
Hide resolved
plyhun
commented
Jan 15, 2025
plyhun
changed the title
npomaroli
requested changes
Jan 28, 2025
core/src/main/java/com/gentics/mesh/cli/AbstractBootstrapInitializer.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/gentics/mesh/core/endpoint/admin/consistency/UploadsConsistencyCheck.java
Show resolved
Hide resolved
.../src/main/java/com/gentics/mesh/core/endpoint/admin/consistency/UploadsConsistencyCheck.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/gentics/mesh/core/endpoint/admin/consistency/UploadsConsistencyCheck.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/gentics/mesh/core/endpoint/admin/consistency/UploadsConsistencyCheck.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/gentics/mesh/core/endpoint/node/NodeCrudHandler.java
Show resolved
Hide resolved
mdm/api/src/main/java/com/gentics/mesh/context/impl/DummyBulkActionContext.java
Show resolved
Hide resolved
services/local-storage/src/main/java/com/gentics/mesh/storage/LocalBinaryStorageImpl.java
Outdated
Show resolved
Hide resolved
tests/tests-core/src/main/java/com/gentics/mesh/core/field/binary/BinaryFieldTest.java
Show resolved
Hide resolved
tests/tests-core/src/main/java/com/gentics/mesh/core/node/NodeImageResizeEndpointTest.java
Show resolved
Hide resolved
npomaroli
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…re of BulkActionContext
Abstract
The current nature of BulkActionContext is weak, allowing it being abandoned at any time with no processing, on the one hand, and ignoring or misplacing it, on the other. Here the part of the BAC refactoring consists of injecting it into the Tx, the same as is done with the event queue, but with paying attention to its processing, started manually (this is the main difference with event queue, that is executed on Tx success automatically). Plus, the extra actions for deletion the folders traces for the deleted binary is implemented, as well as the check/repair for the already abandoned binaries.
Checklist
General
/CHANGELOG.adocOn API Changes