Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2093 metadata #2207

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Issue 2093 metadata #2207

merged 5 commits into from
Dec 5, 2023

Conversation

mugitty
Copy link
Contributor

@mugitty mugitty commented Dec 5, 2023

Updated to generate aggregate gorule document

@mugitty mugitty requested a review from dustine32 December 5, 2023 16:44
@dustine32
Copy link
Contributor

Noting this is tied to a change in pipeline Jenkinsfile. @mugitty Once this change is made into a pipeline repo PR against master it should be referenced to this go-site repo PR.

@kltm
Copy link
Member

kltm commented Dec 5, 2023

I'll let others decide the merge timing, but I'm happy as long as this goes in before geneontology/pipeline#347

Copy link
Contributor

@dustine32 dustine32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kltm @mugitty Sounds like we're all good with the hard-coding?

Note this PR should be merged before merging geneontology/pipeline#347.

@kltm
Copy link
Member

kltm commented Dec 5, 2023

Hard-coding is fine, as long as we get the order/timing correct.

@mugitty mugitty merged commit 4d7b7a2 into master Dec 5, 2023
2 checks passed
@mugitty mugitty deleted the issue-2093-metadata branch December 7, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants