Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade ontobio to check null with from field #2193

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Upgrade ontobio to check null with from field #2193

merged 2 commits into from
Nov 27, 2023

Conversation

mugitty
Copy link
Contributor

@mugitty mugitty commented Nov 27, 2023

@mugitty mugitty requested a review from kltm November 27, 2023 23:34
@mugitty
Copy link
Contributor Author

mugitty commented Nov 27, 2023

For geneontology/pipeline#346

@kltm
Copy link
Member

kltm commented Nov 27, 2023

@mugitty Possible failure wrt #2194 (comment)?

@kltm
Copy link
Member

kltm commented Nov 27, 2023

Otherwise, happy to have you self-merge after passing.

kltm
kltm approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@kltm kltm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, happy to have you self-merge after passing.

@kltm
Copy link
Member

kltm commented Nov 27, 2023

@mugitty Still having the sparta error; perhaps you need to merge in your recent changes?

@kltm kltm merged commit 44ec217 into master Nov 27, 2023
2 checks passed
@mugitty mugitty deleted the pipeline-346-null-withfrom-check branch June 12, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kltm kltm kltm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mugitty @kltm