Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting to collection #67

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bcoca
Copy link

@bcoca bcoca commented Nov 21, 2023

By no way complete or tested, but a start to moving this to a collection, which will enable the current monkey patch vars plugin to work with lastest ansible (at least until we fix current loading bug ansible/ansible#82239 ), but also looking for less fragile and more long term solution.

Also note that the role can continue to exist as is, we do plan to fix the current bug, I just recommend either migrating to or creating additional collection as this makes some of the things this role does easier.

Feel free to discard/use this patch any way you see fit, it is more PoC and suggestion than anything else

done:

  • renamed plugins, so a simple collections: this.collection can allow for 'naked' name overrides, instead of having to rename on the fly.
  • moved plugins into place
  • created roles from existing role
  • added bootstrap.yml playbook and group_vars/openwrt.yml to handle setup
  • used fact gathering config to point to specific 'setup' module (kept clashing name in case of direct invocation), note that new 'gather_facts' action should be used from now on.

missing:

  • docs
    • instructions to copy group_vars to more permanent inventory location
    • howto use collection, both via fqcn and 'short names'
  • action plugin redirection
  • actual action plugin that does most of what is 'monkey patched' today, like inject 'wrapper'.sh
  • testing, testing and testing

@duchenpaul
Copy link

This is an excellent idea, are you going to implement it still?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants