-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements issue #5, Ability to add items to layout/tag by name (search). #45
base: master
Are you sure you want to change the base?
Conversation
I think having the add item to layout option on right-clicks in the bank over empty spaces might be better, what do you think?
downsides:
A checkbox for adding an item's variants might be neat, for stuff like barrows armor. Also, looking at the code (haven't run it yet), it looks like adding an item to a non-open tab will NPE. |
Yep, that'd be better
Maybe, I wouldn't use it personally, but I can see how people would like separate placeholders per variant
Oops! Yeah I wouldn't be surprised if it did, first point should take care of it I've also gone and implemented the ability to open the add item search dialog via hotkey which is really really nice when creating a bunch of them. It's customizable in the settings tab. The default is Ctrl+A (for add). Ctrl+N could be an alternative for the default binding. |
The variants thing I mentioned is not for separate placeholders but for adding variants of an item to the tag only, not the layout, so that if you add barrows armor and it degrades it will still show up in the tag. (EDIT: this is only useful for a few items so it's probably not worth doing anyways).
I don't like the idea of a default keybind because people will have to go to the config panel to even know that it exists, and if they do that they may as well set it themselves. This avoids people asking "why am I no longer able to press ctrl-a" in runelite discord (assuming this can actually happen, it depends on how you implement the hotkey I guess).
Not if they close the tab for some reason. lmao we both made the same errors with not putting empty lines after comments, lol. |
0eebae4
to
1a139f9
Compare
09dc68b
to
af0f042
Compare
f73df36
to
d9f3ae7
Compare
087dc5b
to
0d16889
Compare
I've implemented the ability to add an item to the layout via search. #5
https://www.youtube.com/watch?v=E01dj89zxzg
Have a look if you think this implementation is sufficient.
Could use a code review as it's my first contribution to your project, but it seems to be working great!
Definitely something I was looking for on my group iron.
When adding a bunch of items a keybind for this action would be nice too.
Maybe it'd be nice to add the item on the first visible index, when adding items to a long tab you have to scroll up and drag it over to where you where trying to add something