Create WP_Slack_Plugin after all plugins have loaded #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WP_Slack_Plugin was created when the plugin loaded. Additional plugins that add themselves to the `slack_get_events` filter may not have been loaded yet at that point. So the plugin creates a new `WP_Slack_Event_Manager` object that runs `get_events()` before those "late" plugins have had a chance to hook into the event.
|
Thanks for the PR @rolfkleef |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WP_Slack_Plugin was created when the plugin loaded.
Additional plugins that add themselves to the
slack_get_eventsfilter may not have been loaded yet at that point.So the plugin creates a new
WP_Slack_Event_Managerobject that runsget_events()before those "late" plugins have had a chance to hook into the event.Fixes #38