Corrected forcing data script and added function to run biomee multiple times

[lauramarques]

No description provided.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 87.67123% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 75.77%. Comparing base (5c5c364) to head (4b17ec0).

❗ Current head 4b17ec0 differs from pull request most recent head ffc6e81. Consider uploading reports for the commit ffc6e81 to get more accurate results

Files	Patch %	Lines
src/vegetation_biomee.mod.f90	40.00%	30 Missing ⚠️
src/biosphere_biomee.mod.f90	33.33%	6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   75.56%   75.77%   +0.20%     
==========================================
  Files          36       36              
  Lines        4162     4268     +106     
==========================================
+ Hits         3145     3234      +89     
- Misses       1017     1034      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stineb]

Great you managed to get all checks passing! And great work on all the output variable additions. Just two small remaining points:

• data/biomee_validation_2.rda: how is this different to data/biomee_validation.rda? Can we keep just one of them?
• data-raw/generate_biomee_driver_data_DBEN.R: seems like this should be in the D-BEN repository, not in rsofun

Could you resolve this before I merge @lauramarques?

Did you merge the latest rsofun master into your master before making the PR? If not, please do so.

[lauramarques]

Yes, I will resolve these two points and I also need to add a couple of commits more needed to run the DBEN simulations.
Yes, my fork is up to date with geco-bern/rsofun:master.

[lauramarques]

I have now added the last commits and all checks have passed.
I have deleted data-raw/generate_biomee_driver_data_DBEN.R, and updated data-raw/generate_biomee_driver_data.R
I have removed the duplicate data/biomee_validation.rda.
You can proceed with the merge now.

[stineb]

@lauramarques
I've merged it but there were weird things happening in the merging. I'm resolving this now.
There is hard-coded stuff in there that seems D-BEN-specific ("Reset vegetation to initial conditions" in biosphere_biomee). I'm removing this now. Find a solution to specify the re-setting through modifying the model forcing.

Please remember, when adding code, using indenting.

[lauramarques]

Ok, I see.
The SR reset_vegn_initial only runs when do_reset_veg = TRUE in params_siml. We can specify this when preparing the drivers.