Amends after CRAN feedback

[pepaaran]

• Correct references in DESCRIPTION
• Remove /dontrun statements from docs
• Remove data from 2013 after speaking to Puechabon site responsibles
• Document inputs and outputs of the BiomeE functions

[pepaaran]

@khufkens @stineb

I'm planning to submit this version of the package again to CRAN. Is everything from the copyright, licensing and authors side ready to go?

[khufkens]

@pepaaran from the licensing point of view everything is ok.

Makes sure to adjust your CRAN submission statement and the NEWS file according to the latest changes, including making the licensing more transparent.

The CRAN submission statement in particular must include how you addressed all comments made in the previous rejection of the package (as with peer review in science). If we didn't address an issue it has to be explained why as well (the motivation must hold).

Does this make sense?

[codecov-commenter]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d5f5b0e) 75.68% compared to head (5ea5f88) 75.50%.
Report is 26 commits behind head on master.

❗ Current head 5ea5f88 differs from pull request most recent head b8eb6a5. Consider uploading reports for the commit b8eb6a5 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   75.68%   75.50%   -0.19%     
==========================================
  Files          36       36              
  Lines        4175     4172       -3     
==========================================
- Hits         3160     3150      -10     
- Misses       1015     1022       +7     

Files	Coverage Δ
R/init_dates_dataframe.R	100.00% <ø> (ø)
R/run_pmodel_f_bysite.R	80.57% <100.00%> (-0.44%)	⬇️
R/runread_biomee_f.R	100.00% <ø> (ø)
src/biosphere_biomee.mod.f90	100.00% <ø> (ø)
src/biosphere_pmodel.mod.f90	100.00% <ø> (ø)
src/classdefs.mod.f90	11.38% <ø> (ø)
src/datatypes.mod.f90	96.07% <ø> (ø)
src/forcing_siterun_biomee.mod.f90	78.57% <ø> (ø)
src/forcing_siterun_pmodel.mod.f90	86.04% <100.00%> (ø)
src/gpp_biomee.mod.f90	84.70% <ø> (ø)
... and 18 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pepaaran]

Okay, thanks for the reminder.

I added explanations of how we addressed the issues. Could one of you check it to make sure that the text about the copyright and so on is correct? @khufkens @stineb

[khufkens]

OK, looks good thanks

[khufkens]

still looks good