When using python2 handle with care unicode characters during parsing services.gradle.org #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yantonov
force-pushed
the
unicode_fix_for_python2
branch
from
a3a9645 to
390f9c7
Compare
Required only for python2, that's why additional condition was added
yantonov
force-pushed
the
unicode_fix_for_python2
branch
from
390f9c7 to
74ad141
Compare
yantonov
changed the title
dantesun
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: services.gradle.org now responds with utf-8 strings.
This review provides the corresponding fix (required only for python2)