This repository has been archived by the owner on Mar 15, 2020. It is now read-only.
Make site fastbootable #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 11, 2017 08:27
# Conflicts: # package.json # yarn.lock
|
We used to have |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the site fastbootable, enabling the discussion about possible hosting options to take place (#77).
To run locally:
npm start, this command runs both versions of the site (onlocalhost:4200andlocalhost:3000concurrently).Improvements:
Currently the entire package response is inserted into the shoebox, which bloats the index.html file. A potential solution would be to add a new server endpoint which only returns the current page's packages.
This endpoint would be called in fastboot mode to hydrate the immediate page, before requesting the entire package list once booted in the browser.
@gcollazo @stefanpenner thoughts?