-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for translations #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your help setting this up! I only have suggestions about some details; the overall process is very good!
Co-authored-by: Eldred Habert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's step 1 done :)
Hi folks! Thanks for trying out the i18-helpers, I hope they're useful? I just wanted to let you know that I've released them as a stand-alone crate now: https://crates.io/crates/mdbook-i18n-helpers. That should let you clean up the code here a bit 🙂 I noticed you use Please open issues in the repository for any problems you run into. Thanks! |
Wow, thanks a lot @mgeisler ! I'll open another issue with the points you mentioned so we can take a look at this later. Thanks again for the amazing translation system, it's working very nice for us! |
Thanks for the feedback, I'm very happy it works for you! |
Hey @avivace, I wanted to let you know about google/mdbook-i18n-helpers#46. The current For this to work smoothly with existing translations, I've written a conversion tool: google/mdbook-i18n-helpers#46. When that is merged, I will make a new release. I hope you will be able to migrate to it as well. Eventually, I want to release a GitHub action for all this: google/mdbook-i18n-helpers#48. That should make your life easier since you can export the complexity back to the mdbook-i18n-helpers repository 😄 |
I added a link to this projects in the mdbook-i18n-helpers README: google/mdbook-i18n-helpers#49. I hope you don't mind? |
Sure, go ahead and thanks for the mention @mgeisler !
This sounds very interesting and cleaning up the strings from formatting is definitely appreciated. Feel free to ping me when the migration tool is ready!
This is also interesting, maybe it can help automate our current workflow, which requires uploading the base po to crowdin.. |
The converter tool is part of the new 0.2 release which I made last week. I've created PRs for Comprehensive Rust today to update the translations. As an example, the Brazilian Portuguese page on scalar types is using the new system — the table you see there is translated cell-by-cell. If we change one of them in the English original, the others will remain translated. |
Closes #25
Based on the i18n support implemented in https://github.com/google/comprehensive-rust