Log environment variables with which gazebo was launched #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be useful for debugging scenarios where we want to debug why a simulation is not loading the correct files. Signed-off-by: Arjo Chakravarty <[email protected]>
|
This is something usefull, let me know when it's ready for review |
azeey
reviewed
Jan 7, 2025
| @@ -126,7 +127,9 @@ def launch_gz(context, *args, **kwargs): | |||
| else: | |||
| on_exit = None | |||
|
|
|||
| return [ExecuteProcess( | |||
| return [ | |||
| LogInfo(f"Launching gazebo with the environment variables: {env}"), | |||
There was a problem hiding this comment.
I'm not sure if it's always safe to print the environment variables. Maybe be it can be enabled via a launch config?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #
Summary
This can be useful for debugging scenarios where we want to debug why a simulation is not loading the correct files.
Test it
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.