Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend wide angle cameras to support L8 and L16 image formats #1097

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jan 9, 2025

🎉 New feature

Closes gazebosim/gz-sensors#479

Related PR: gazebosim/gz-sensors#494

Summary

Added support for wide angle cameras to read image data back in L8 and L16 image formats for ogre and ogre2

Test it

Updated INTEGRATION_wide_angle_camera test.

From your colcon's gz-rendering's build folder, you can run tests like this:

GZ_ENGINE_TO_TEST=ogre2  ./bin/INTEGRATION_wide_angle_camera
GZ_ENGINE_TO_TEST=ogre  ./bin/INTEGRATION_wide_angle_camera

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 merged commit 84c748e into gz-rendering9 Jan 10, 2025
10 of 11 checks passed
@iche033 iche033 deleted the wideanglecam_mono branch January 10, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

WideAngleCameraSensor only supports RGB8 format, not L8 as in Classic
2 participants