Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package.xml #608

Merged
merged 6 commits into from
May 3, 2024
Merged

Add package.xml #608

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b800913
Add package.xml
azeey Mar 18, 2024
b2fe784
Merge remote-tracking branch 'origin/gz-physics7' into azeey/package_xml
azeey Apr 10, 2024
26da03e
Update version
azeey Apr 10, 2024
4e523ee
Merge branch 'gz-physics7' into azeey/package_xml
azeey Apr 19, 2024
c28a927
Merge remote-tracking branch 'origin/gz-physics7' into azeey/package_xml
azeey May 3, 2024
df390df
Address reviewer feedback
azeey May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/package_xml.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
name: Validate package.xml

on:
pull_request:

jobs:
package-xml:
runs-on: ubuntu-latest
name: Validate package.xml
steps:
- uses: gazebo-tooling/action-gz-ci/validate_package_xml@jammy
27 changes: 27 additions & 0 deletions package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
<?xml version="1.0"?>
<package format="2">
<name>gz-physics7</name>
<version>7.2.0</version>
<description>Gazebo Physics : Physics classes and functions for robot applications</description>
<maintainer email="[email protected]">Steve Peters</maintainer>
<license>Apache License 2.0</license>
<url type="website">https://github.com/gazebosim/gz-physics</url>

<buildtool_depend>cmake</buildtool_depend>

<build_depend>gz-cmake</build_depend>
azeey marked this conversation as resolved.
Show resolved Hide resolved

<depend>benchmark</depend>
<depend>bullet</depend>
<depend>dartsim</depend>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know dartsim uses this name in its package.xml file, but I had added a colcon.pkg file to change its package name for colcon's purposes to DART so that colcon-cmake would recognize find_package(DART) (see dartsim/dart#1389)

I haven't yet tried to build a workspace with gz-physics, dartsim, bullet and ODE, and we don't need to block on this, but I'm not sure building all those from source in the same workspace will work properly in this current form

Copy link
Contributor Author

@azeey azeey May 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I used colcon graph and saw that gz-physics didn't have a dependency on DART, so I've changed it in df390df

Before

DART            +
gz-cmake3        +********* *****
gz-tools2         +  * ***..*****
gz-utils2          +***.******.*.
gz-math7            + ***********
gz-plugin2           +    ** *.**
gz-common5            +  *** ****
gz-msgs10              + *  *****
sdformat14              + *   ***
gz-fuel_tools9           +     *.
gz-physics7               +    **
gz-rendering8              + ****
gz-transport13              +****
gz-gui8                      + **
gz-sensors8                   +**
gz-sim8                        +*
gz-launch7                      +

After

DART            +         *    ..
gz-cmake3        +********* *****
gz-tools2         +  * ***..*****
gz-utils2          +***.******.*.
gz-math7            + ***********
gz-plugin2           +    ** *.**
gz-common5            +  *** ****
gz-msgs10              + *  *****
sdformat14              + *   ***
gz-fuel_tools9           +     *.
gz-physics7               +    **
gz-rendering8              + ****
gz-transport13              +****
gz-gui8                      + **
gz-sensors8                   +**
gz-sim8                        +*
gz-launch7                      +

<depend>eigen</depend>
<depend>gz-common5</depend>
<depend>gz-math7</depend>
<depend>gz-plugin2</depend>
<depend>gz-utils2</depend>
<depend>sdformat14</depend>

<export>
<build_type>cmake</build_type>
</export>
</package>