Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: gz-msgs9 to gz-msgs10 #429

Merged
merged 3 commits into from
Mar 11, 2024
Merged

port: gz-msgs9 to gz-msgs10 #429

merged 3 commits into from
Mar 11, 2024

Conversation

mjcarroll
Copy link
Contributor

➡️ Forward port

Port gz-msgs9 to gz-msgs10

Branch comparison: gz-msgs10...gz-msgs9

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

…428)

The current implementation allows for additional messages to be read from these files, it was just not properly configured for the files to be accessible

Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll requested a review from caguero as a code owner March 11, 2024 18:20
@mjcarroll mjcarroll self-assigned this Mar 11, 2024
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Mar 11, 2024
Signed-off-by: Michael Carroll <[email protected]>
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.19%. Comparing base (b35b9fd) to head (1939fb0).

Files Patch % Lines
core/src/DynamicFactory.cc 96.15% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           gz-msgs10     #429      +/-   ##
=============================================
+ Coverage      97.67%   98.19%   +0.52%     
=============================================
  Files             27       27              
  Lines           1163     1166       +3     
=============================================
+ Hits            1136     1145       +9     
+ Misses            27       21       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjcarroll mjcarroll merged commit f253f69 into gz-msgs10 Mar 11, 2024
11 of 12 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/port/9_to_10 branch March 11, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants