homebrew_formula_pullrequest: unique branch name #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1020. Signed-off-by: Steve Peters <[email protected]>
|
that pull request updater job failed so I'm retrying it with this branch: |
|
the first pull request (osrf/homebrew-simulation#2491) has the wrong sha256 the new pull request (osrf/homebrew-simulation#2492) made with this branch has the right sha256 |
|
it worked! |
j-rivero
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The homebrew formula pull requests sometimes are triggered twice, but the second pull request is not created due to overlapping branch names. This gives each pull request a unique branch name so that duplicate pull requests will be created, and the maintainer can figure out which has the correct tarball SHA.
Fixes #1020.