Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add healthz endpoints #353

Merged
merged 2 commits into from
Oct 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ type Options struct {
GRPCNetwork string
GRPCAddress string
HTTPAddress string
Servers map[string]*network.Server
}

type API struct {
v1.GatewayDAdminAPIServiceServer

Expand Down
4 changes: 3 additions & 1 deletion api/grpc_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,12 @@ import (

v1 "github.com/gatewayd-io/gatewayd/api/v1"
"google.golang.org/grpc"
"google.golang.org/grpc/health/grpc_health_v1"
"google.golang.org/grpc/reflection"
)

// StartGRPCAPI starts the gRPC API.
func StartGRPCAPI(api *API) {
func StartGRPCAPI(api *API, healthchecker *HealthChecker) {
listener, err := net.Listen(api.Options.GRPCNetwork, api.Options.GRPCAddress)
if err != nil {
api.Options.Logger.Err(err).Msg("failed to start gRPC API")
Expand All @@ -18,6 +19,7 @@ func StartGRPCAPI(api *API) {
grpcServer := grpc.NewServer()
reflection.Register(grpcServer)
v1.RegisterGatewayDAdminAPIServiceServer(grpcServer, api)
grpc_health_v1.RegisterHealthServer(grpcServer, healthchecker)
if err := grpcServer.Serve(listener); err != nil {
api.Options.Logger.Err(err).Msg("failed to start gRPC API")
}
Expand Down
38 changes: 38 additions & 0 deletions api/healthcheck.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
package api

import (
"context"

"github.com/gatewayd-io/gatewayd/network"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/health/grpc_health_v1"
"google.golang.org/grpc/status"
)

type HealthChecker struct {
grpc_health_v1.UnimplementedHealthServer

Servers map[string]*network.Server
}

func (h *HealthChecker) Check(
context.Context, *grpc_health_v1.HealthCheckRequest,
) (*grpc_health_v1.HealthCheckResponse, error) {
// Check if all servers are running
if liveness(h.Servers) {
return &grpc_health_v1.HealthCheckResponse{
Status: grpc_health_v1.HealthCheckResponse_SERVING,
}, nil
}

return &grpc_health_v1.HealthCheckResponse{
Status: grpc_health_v1.HealthCheckResponse_NOT_SERVING,
}, nil
}

func (h *HealthChecker) Watch(
*grpc_health_v1.HealthCheckRequest,
grpc_health_v1.Health_WatchServer,
) error {
return status.Error(codes.Unimplemented, "not implemented") //nolint:wrapcheck
}
38 changes: 28 additions & 10 deletions api/http_server.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package api

import (
"context"
"encoding/json"
"io/fs"
"net/http"

Expand All @@ -12,6 +13,10 @@ import (
"google.golang.org/grpc/credentials/insecure"
)

type Healthz struct {
Status string `json:"status"`
}

// StartHTTPAPI starts the HTTP API.
func StartHTTPAPI(options *Options) {
ctx := context.Background()
Expand All @@ -30,25 +35,38 @@ func StartHTTPAPI(options *Options) {

mux := http.NewServeMux()
mux.Handle("/", rmux)
mux.HandleFunc("/health", func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(http.StatusOK)
mux.HandleFunc("/healthz", func(writer http.ResponseWriter, r *http.Request) {
if liveness(options.Servers) {
writer.Header().Set("Content-Type", "application/json")
writer.WriteHeader(http.StatusOK)
if err := json.NewEncoder(writer).Encode(Healthz{Status: "SERVING"}); err != nil {
options.Logger.Err(err).Msg("failed to serve healthcheck")
writer.WriteHeader(http.StatusInternalServerError)
}
} else {
writer.Header().Set("Content-Type", "application/json")
writer.WriteHeader(http.StatusServiceUnavailable)
if err := json.NewEncoder(writer).Encode(Healthz{Status: "NOT_SERVING"}); err != nil {
options.Logger.Err(err).Msg("failed to serve healthcheck")
}
}
})

mux.HandleFunc("/version", func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(http.StatusOK)
if _, err := w.Write([]byte(config.Version)); err != nil {
mux.HandleFunc("/version", func(writer http.ResponseWriter, r *http.Request) {
writer.WriteHeader(http.StatusOK)
if _, err := writer.Write([]byte(config.Version)); err != nil {
options.Logger.Err(err).Msg("failed to serve version")
w.WriteHeader(http.StatusInternalServerError)
writer.WriteHeader(http.StatusInternalServerError)
}
})

if IsSwaggerEmbedded() {
mux.HandleFunc("/swagger.json", func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(http.StatusOK)
mux.HandleFunc("/swagger.json", func(writer http.ResponseWriter, r *http.Request) {
writer.WriteHeader(http.StatusOK)
data, _ := swaggerUI.ReadFile("v1/api.swagger.json")
if _, err := w.Write(data); err != nil {
if _, err := writer.Write(data); err != nil {
options.Logger.Err(err).Msg("failed to serve swagger.json")
w.WriteHeader(http.StatusInternalServerError)
writer.WriteHeader(http.StatusInternalServerError)
}
})

Expand Down
14 changes: 14 additions & 0 deletions api/utils.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package api

import (
"github.com/gatewayd-io/gatewayd/network"
)

func liveness(servers map[string]*network.Server) bool {
for _, v := range servers {
if !v.IsRunning() {
return false
}
}
return true
}
19 changes: 11 additions & 8 deletions cmd/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -696,16 +696,19 @@ var runCmd = &cobra.Command{
GRPCNetwork: conf.Global.API.GRPCNetwork,
GRPCAddress: conf.Global.API.GRPCAddress,
HTTPAddress: conf.Global.API.HTTPAddress,
Servers: servers,
}

go api.StartGRPCAPI(&api.API{
Options: &apiOptions,
Config: conf,
PluginRegistry: pluginRegistry,
Pools: pools,
Proxies: proxies,
Servers: servers,
})
go api.StartGRPCAPI(
&api.API{
Options: &apiOptions,
Config: conf,
PluginRegistry: pluginRegistry,
Pools: pools,
Proxies: proxies,
Servers: servers,
},
&api.HealthChecker{Servers: servers})
logger.Info().Str("address", apiOptions.HTTPAddress).Msg("Started the HTTP API")

go api.StartHTTPAPI(&apiOptions)
Expand Down