Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add healthz endpoints #353

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Add healthz endpoints #353

merged 2 commits into from
Oct 24, 2023

Conversation

mostafa
Copy link
Member

@mostafa mostafa commented Oct 24, 2023

Ticket(s)

Description

This PR adds health check probes. All the probes return whether all the servers are running or not. The health check works both on the gRPC server and the HTTP server and can be tested using the following commands:

$ curl http://localhost:18080/healthz       
{"status":"SERVING"}
$ grpc-client-cli health localhost:19090 
{
 "status":  "SERVING"
}

Related PRs

N/A

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) and type annotations to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have added tests for my changes.

Legal Checklist

@mostafa mostafa linked an issue Oct 24, 2023 that may be closed by this pull request
@mostafa mostafa force-pushed the add-healthz-endpoints branch from 2d71bda to 32ab95a Compare October 24, 2023 17:46
@mostafa mostafa merged commit 98354ae into main Oct 24, 2023
2 checks passed
@mostafa mostafa deleted the add-healthz-endpoints branch October 24, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add liveness, readiness and startup probes to API
1 participant