Move trace attributes inside null checking block

Exit GatewayD if connections cannot be made Update exit codes
gatewayd-io · Mar 6, 2023 · dce05ce · dce05ce
1 parent 9f2781b
commit dce05ce
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 21 deletions.
diff --git a/cmd/run.go b/cmd/run.go
@@ -323,28 +323,28 @@ var runCmd = &cobra.Command{
 				clientConfig := clients[name]
 				client := network.NewClient(runCtx, &clientConfig, logger)
 
-				eventOptions := trace.WithAttributes(
-					attribute.String("name", name),
-					attribute.String("network", client.Network),
-					attribute.String("address", client.Address),
-					attribute.Int("receiveBufferSize", client.ReceiveBufferSize),
-					attribute.Int("receiveChunkSize", client.ReceiveChunkSize),
-					attribute.String("receiveDeadline", client.ReceiveDeadline.String()),
-					attribute.String("sendDeadline", client.SendDeadline.String()),
-					attribute.Bool("tcpKeepAlive", client.TCPKeepAlive),
-					attribute.String("tcpKeepAlivePeriod", client.TCPKeepAlivePeriod.String()),
-					attribute.String("localAddress", client.Conn.LocalAddr().String()),
-					attribute.String("remoteAddress", client.Conn.RemoteAddr().String()),
-				)
-				if client.ID != "" {
-					eventOptions = trace.WithAttributes(
-						attribute.String("id", client.ID),
+				if client != nil {
+					eventOptions := trace.WithAttributes(
+						attribute.String("name", name),
+						attribute.String("network", client.Network),
+						attribute.String("address", client.Address),
+						attribute.Int("receiveBufferSize", client.ReceiveBufferSize),
+						attribute.Int("receiveChunkSize", client.ReceiveChunkSize),
+						attribute.String("receiveDeadline", client.ReceiveDeadline.String()),
+						attribute.String("sendDeadline", client.SendDeadline.String()),
+						attribute.Bool("tcpKeepAlive", client.TCPKeepAlive),
+						attribute.String("tcpKeepAlivePeriod", client.TCPKeepAlivePeriod.String()),
+						attribute.String("localAddress", client.Conn.LocalAddr().String()),
+						attribute.String("remoteAddress", client.Conn.RemoteAddr().String()),
 					)
-				}
+					if client.ID != "" {
+						eventOptions = trace.WithAttributes(
+							attribute.String("id", client.ID),
+						)
+					}
 
-				span.AddEvent("Create client", eventOptions)
+					span.AddEvent("Create client", eventOptions)
 
-				if client != nil {
 					clientCfg := map[string]interface{}{
 						"id":                 client.ID,
 						"network":            client.Network,
@@ -367,6 +367,9 @@ var runCmd = &cobra.Command{
 						logger.Error().Err(err).Msg("Failed to add client to the pool")
 						span.RecordError(err)
 					}
+				} else {
+					logger.Error().Msg("Failed to create client, please check the configuration")
+					os.Exit(gerr.FailedToCreateClient)
 				}
 			}
 

diff --git a/errors/errors.go b/errors/errors.go
@@ -105,6 +105,7 @@ var (
 const (
 	FailedToLoadPluginConfig = 1
 	FailedToLoadGlobalConfig = 2
-	FailedToInitializePool   = 3
-	FailedToStartServer      = 4
+	FailedToCreateClient     = 3
+	FailedToInitializePool   = 4
+	FailedToStartServer      = 5
 )