fix: Update punycode import path
#99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With later Node versions, deprecation warnings began to appear about changing the import path to avoid using core modules, instead to use userland modules. This follows the advice for `punycode`'s most recent version (v2.3.1). This should ideally be applied for a v4.4.2 tag so a number of active packages can remove this warning.
|
There is already something #95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With later Node versions, deprecation warnings began to appear about
changing the import path to avoid using core modules, instead to use
userland modules. This follows the advice for
punycode's most recentversion (v2.3.1). This should ideally be applied for a v4.4.2 tag so
a number of active packages can remove this warning.