Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #78

Merged
merged 4 commits into from
Jan 14, 2024
Merged

Bump dependencies #78

merged 4 commits into from
Jan 14, 2024

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Jan 1, 2024

No description provided.

@danyeaw
Copy link
Member Author

danyeaw commented Jan 8, 2024

@amolenaar The build for this is currently failing due to the install-schemas step. Any thoughts on what we should do about this? Some potential options:

  1. Install Gaphor from source and then run poe install-schemas
  2. Remove the gaphor --self-test check in CI for this repo
  3. Change the gaphor --self-test to allow ignoring that schemas aren't installed
  4. Try to test this with a Flatpak version of the app

@amolenaar
Copy link
Member

Not having the schemas installed makes the self test kinda useless outside of our packaged versions.

For now I think it's okay to skip the self test step.

Maybe we should bundle the schemas with the pypi package and provide a gaphor install-schemas cli command?

@danyeaw danyeaw requested a review from amolenaar January 9, 2024 21:23
@danyeaw danyeaw merged commit f9a1588 into main Jan 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants