372 bug chance action probabilities after deleting chance action

[rahulsavani]

This is now a single commit with a ChangeLog entry, and is so ready for review and possible merging

[tturocy]

See the one improvement in terms of localising this change to TreeGameRep alone. Otherwise this looks ready to merge - if you can squash and force-push first that'd certainly be helpful!

[tturocy]

Having a separate NormaliseChanceProbs function makes sense, but it doesn't need to be a member of GameRep. It just needs to be present in TreeGameRep as that's the only representation (at least at the moment) that implements the operation. That means changes to the other representation classes can be rolled back.

Further, within TreeGameRep, this should be a private member function; there's no reason for external code to call this as having the probabilities be summing to one should already be maintained as an invariant.

[tturocy]

You've accidentally added the .idea config files in the commit. We do actually need to have a conversation about which ones we should include - because these can control things like static code checkers and formatters using those. But that's something for another time!

[rahulsavani]

You've accidentally added the .idea config files in the commit. We do actually need to have a conversation about which ones we should include - because these can control things like static code checkers and formatters using those. But that's something for another time!

Yep I did a git add . a one point and apparently didn't clear up fully. That's been dealt with now and squashed.