ENH-353-initialisation of mixed profiles on creation #368
Conversation
src/pygambit/game.pxi
Outdated
| specifying the probabilities of the strategies. | ||
|
|
||
| rational | ||
| If `True`, probabilities are represented using rational numbers; otherwise |
There was a problem hiding this comment.
It appears that numpydoc convention is that when referring to Python constants like True, False, None and so on, not to enclose them in any back-ticks at all (as in the original version of the docstring)
src/pygambit/tests/test_behav.py
Outdated
| @@ -7,7 +7,7 @@ def setUp(self): | |||
| "test_games/mixed_behavior_game.efg" | |||
| ) | |||
| self.profile_double = self.game.mixed_behavior_profile() | |||
| self.profile_rational = self.game.mixed_behavior_profile(True) | |||
| self.profile_rational = self.game.mixed_behavior_profile(None, True) | |||
There was a problem hiding this comment.
It would be useful to add a test of creating the behavior profile set to a specific distribution, exercising the new code.
|
Thanks for the suggestions and the requests. |
tturocy
force-pushed
the
ENH-353-initialisation-of-mixed-profiles-on-creation
branch
from
003c70f to
51e3507
Compare
tturocy
force-pushed
the
ENH-353-initialisation-of-mixed-profiles-on-creation
branch
from
51e3507 to
570b8b4
Compare
There was a problem hiding this comment.
I have made a few small comments. However, because the test suite has been rewritten for MixedBehaviorProfile the tests aren't going to merge. I would suggest making the changes on a new branch from latest master. - you should just be able to copy-paste in the changes in game.pxi and then write the test of creating with a given distribution in the new style.
| @@ -8,14 +8,18 @@ def setUp(self): | |||
| self.game = gbt.Game.read_game( | |||
| "test_games/mixed_behavior_game.efg" | |||
| ) | |||
| self.profile_double = self.game.mixed_behavior_profile(False) | |||
| self.profile_rational = self.game.mixed_behavior_profile(True) | |||
| self.profile_double = self.game.mixed_behavior_profile(None, rational=False) | |||
There was a problem hiding this comment.
The None here is unnecessary given that the rational= parameter name has been added
| assert profile[self.game_with_chance.players[0]] == data_double[0] | ||
| assert profile[self.game_with_chance.players[1]] == data_double[1] | ||
|
|
||
| def test_probabilities_infoset_by_label_for_specific_distribution(self): |
| assert profile["Infoset 2:1"] == data_double[1][0] | ||
| assert profile["Infoset 3:1"] == data_double[2][0] | ||
|
|
||
| def test_normalize(self): |
tturocy
deleted the
ENH-353-initialisation-of-mixed-profiles-on-creation
branch
No description provided.