Invert pull up config value, fixes wled#2996

Cronixie usermod format change fix
gabyleon · Jan 3, 2023 · d039a40 · d039a40
1 parent e961691
commit d039a40
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/usermods/Cronixie/usermod_cronixie.h b/usermods/Cronixie/usermod_cronixie.h
@@ -271,6 +271,7 @@ class UsermodCronixie : public Usermod {
     {
       if (root["nx"].is<const char*>()) {
         strncpy(cronixieDisplay, root["nx"], 6);
+        setCronixie();
       }
     }
 

diff --git a/wled00/cfg.cpp b/wled00/cfg.cpp
@@ -198,9 +198,8 @@ bool deserializeConfig(JsonObject doc, bool fromFS) {
 
   // read multiple button configuration
   JsonObject btn_obj = hw["btn"];
-  int pull = -1; // trick for inverted setting
-  CJSON(pull, btn_obj[F("pull")]);
-  if (pull>=0) disablePullUp = pull;
+  bool pull = btn_obj[F("pull")] | true; // if true, pullup is enabled
+  disablePullUp = !pull;
   JsonArray hw_btn_ins = btn_obj[F("ins")];
   if (!hw_btn_ins.isNull()) {
     uint8_t s = 0;
-Original file line number
+Diff line change
@@ Expand Up / @@ -271,6 +271,7 @@ class UsermodCronixie : public Usermod { @@
         {
           if (root["nx"].is<const char*>()) {
             strncpy(cronixieDisplay, root["nx"], 6);
+            setCronixie();
           }
         }
@@ Expand Down @@