Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: macos runner image #109

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

tanzaku
Copy link
Collaborator

@tanzaku tanzaku commented Nov 11, 2024

mac(intel版)でvscode拡張によるSQLフォーマットできない不具合が発生しており、その対応です。

x86_64向けのBuildジョブuroborosql-fmt-napi.darwin-arm64.node が作成されることが原因のようです。
actions/runner-images#9741 (comment) を参考に、mac(intel版)については macos-latest-large のイメージを使用するよう変更しました。

@ota-meshi

@tanzaku tanzaku requested a review from ota-meshi November 11, 2024 02:36
@tanzaku tanzaku marked this pull request as draft November 11, 2024 02:40
@tanzaku tanzaku marked this pull request as ready for review November 11, 2024 02:52
@tanzaku
Copy link
Collaborator Author

tanzaku commented Nov 11, 2024

larger runnerは現在のプランでは使えずエラーになっていたため macos-13 に変更しました。
この変更により Buildジョブuroborosql-fmt-napi.darwin-x64.node が作成されるようになったことを確認しています。

2024-11-11T02:49:32.731Z napi:build Platform: darwin
2024-11-11T02:49:32.753Z napi:build Platform name: .darwin-x64
2024-11-11T02:49:32.754Z napi:build Write binary content to [uroborosql-fmt-napi.darwin-x64.node]

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ota-meshi ota-meshi merged commit e5b24e9 into main Nov 11, 2024
8 checks passed
@ota-meshi ota-meshi deleted the not_working_vscode_extension_on_mac_intel_ver branch November 11, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants