Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin refactoring plan #53

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Plugin refactoring plan #53

merged 1 commit into from
Jun 17, 2019

Conversation

sseago
Copy link
Contributor

@sseago sseago commented Jun 12, 2019

First iteration of the plan to split ocp-velero-plugin into
two separate velero plugins:

  1. A general openshift plugin, appropriate for situations
    in which velero is used for general backup and restore
    of OpenShift namespaces.
  2. A migration plugin, intended to be used only in conjunction
    with the Migration Controller.

dymurray
dymurray approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good. I would maybe add a plan about vendoring the general plugin as a dep just so it is clear how we accomplish the ability to only register the migration plugin without duplicating code.

Looks great thanks Scott

@sseago
Plugin refactoring plan
730a270 
First iteration of the plan to split ocp-velero-plugin into
two separate velero plugins:

1) A general openshift plugin, appropriate for situations
   in which velero is used for general backup and restore
   of OpenShift namespaces.
2) A migration plugin, intended to be used only in conjunction
   with the Migration Controller.
@sseago
Copy link
Contributor Author

sseago commented Jun 17, 2019

Merging with update to reference vendoring of the general plugin code in the migration plugin.

@sseago sseago merged commit cedbefe into fusor:master Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dymurray dymurray dymurray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sseago @dymurray