Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pdf_creater): add exception handling for show_pdf_page operations #119

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

awwaawwa
Copy link
Member

Description

This PR adds proper exception handling and logging for show_pdf_page operations in the dual PDF creation process.

Changes

  • Added try-except blocks around show_pdf_page calls
  • Added detailed error logging with page ID and file information
  • Improved error handling to ensure the process continues even if rendering of specific pages fails

Testing

The code has been tested with problematic PDFs that previously caused rendering issues.

Related Issues

Resolves issues with PDF rendering errors during dual PDF creation.

@awwaawwa awwaawwa merged commit e9c349a into main Feb 25, 2025
11 checks passed
@awwaawwa awwaawwa deleted the fix/pdf-creater-exception-handling branch February 27, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant