refactor: Rename, add type annotations, remove redundant code, and so on

funstory-ai · Feb 25, 2025 · b2fbd2b · b2fbd2b
1 parent 572f29e
commit b2fbd2b
Show file tree

Hide file tree

Showing 6 changed files with 129 additions and 160 deletions.
diff --git a/babeldoc/const.py b/babeldoc/const.py
@@ -7,7 +7,7 @@
 CACHE_FOLDER = Path.home() / ".cache" / "babeldoc"
 
 
-def get_cache_file_path(filename):
+def get_cache_file_path(filename: str) -> Path:
     return CACHE_FOLDER / filename
 
 

diff --git a/babeldoc/document_il/midend/paragraph_finder.py b/babeldoc/document_il/midend/paragraph_finder.py
@@ -254,9 +254,9 @@ def get_layout(
         self,
         char: PdfCharacter,
         page: Page,
-        xy_mode: Literal["topleft"]
-        | Literal["bottomright"]
-        | Literal["middle"] = "middle",
+        xy_mode: (
+            Literal["topleft"] | Literal["bottomright"] | Literal["middle"]
+        ) = "middle",
     ):
         tl, br, md = [
             self._get_layout(char, page, mode)
@@ -279,9 +279,9 @@ def _get_layout(
         self,
         char: PdfCharacter,
         page: Page,
-        xy_mode: Literal["topleft"]
-        | Literal["bottomright"]
-        | Literal["middle"] = "middle",
+        xy_mode: (
+            Literal["topleft"] | Literal["bottomright"] | Literal["middle"]
+        ) = "middle",
     ):
         # 这几个符号，解析出来的大小经常只有实际大小的一点点。
         # if (

diff --git a/babeldoc/document_il/translator/translator.py b/babeldoc/document_il/translator/translator.py
@@ -5,6 +5,7 @@
 import time
 import unicodedata
 from abc import ABC
+from abc import abstractmethod
 
 import openai
 import requests
@@ -115,6 +116,7 @@ def translate(self, text, ignore_cache=False):
             self.cache.set(text, translation)
         return translation
 
+    @abstractmethod
     def do_translate(self, text):
         """
         Actual translate text, override this method

diff --git a/babeldoc/docvision/doclayout.py b/babeldoc/docvision/doclayout.py
@@ -28,10 +28,9 @@ def load_available():
     @abc.abstractmethod
     def stride(self) -> int:
         """Stride of the model input."""
-        pass
 
     @abc.abstractmethod
-    def predict(self, image, imgsz=1024, **kwargs) -> list:
+    def predict(self, image: bytes, imgsz: int = 1024, **kwargs) -> list[int]:
         """
         Predict the layout of a document page.
 
@@ -40,7 +39,6 @@ def predict(self, image, imgsz=1024, **kwargs) -> list:
             imgsz: Resize the image to this size. Must be a multiple of the stride.
             **kwargs: Additional arguments.
         """
-        pass
 
 
 class YoloResult: