Merge pull request #22 from fungenomics/issue/11

Create unit testing for sum_n_first_fibonacci_numbers.
fungenomics · May 14, 2020 · 56b5aa1 · 56b5aa1
2 parents 37b8402 + 8bd5141
commit 56b5aa1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/R/sum_first_fibonacci_numbers.R b/R/sum_first_fibonacci_numbers.R
@@ -9,6 +9,9 @@
 #' sum_n_first_fibonacci_numbers(5)
 #' sum_n_first_fibonacci_numbers(8)
 sum_n_first_fibonacci_numbers <- function(n){
+  if(n < 0){
+    stop("Please use a positive number")
+  }
   if(length(fibonacci) < n){
     print(paste0("Fibonacci vector's length is ", length(fibonacci), ". Summing the ", length(fibonacci), " first numbers instead."))
     return(sum(fibonacci))

diff --git a/tests/testthat/test-sum_n_first_fibonacci_numbers.R b/tests/testthat/test-sum_n_first_fibonacci_numbers.R
@@ -0,0 +1,7 @@
+test_that("sum_n_first_fibonacci_numbers works", {
+  expect_equal(sum_n_first_fibonacci_numbers(4), 7)
+})
+
+ test_that("sum_n_first_fibonacci_numbers handles edge cases", {
+     expect_error(sum_n_first_fibonacci_numbers(-3), "Please use a positive number")
+ })