Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For 2D gene plotting, fix the case when a gene has 0 expression in all samples in one region #35

Open
sjessa opened this issue Jun 26, 2021 · 4 comments
Assignees
Labels
bug Something isn't working clusters-app

Comments

@sjessa
Copy link
Member

sjessa commented Jun 26, 2021

Ideally we could display an error, but otherwise we could display the plots with all 0 values, as we do in the case where only one sample has 0 expression across all cells?

In this case, the error shows up for forebrain, but not for pons:

image

@sjessa sjessa added bug Something isn't working clusters-app labels Jun 26, 2021
@sjessa sjessa assigned sjessa and bhavyaac and unassigned sjessa Jun 28, 2021
@bhavyaac
Copy link
Member

bhavyaac commented Jun 28, 2021

I plan to display a descriptive error message using validate() -"This gene has no detected expression in the selected brain region". I will display it in place of the expression-related dimensionality reduction plots & violin plots (Single cell expression by region & by sample tabs) as well as in the timecourse plot (which also displays an error in this case - see below).
Screen Shot 2021-06-28 at 11 12 17 AM

@bhavyaac
Copy link
Member

bhavyaac commented Jun 28, 2021

Previews for dimensionality reduction plots and violin plots:
Screen Shot 2021-06-28 at 11 46 02 AM
Screen Shot 2021-06-28 at 11 46 14 AM
Screen Shot 2021-06-28 at 11 46 58 AM

@sjessa
Copy link
Member Author

sjessa commented Jun 28, 2021

@bhavyaac I think that looks great! That validate() function looks like it will be super handy!

@bhavyaac
Copy link
Member

Update: tested this in the server and it doesn't work currently, I'll have to do some more adjustments & try to test locally to get it working!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working clusters-app
Projects
None yet
Development

No branches or pull requests

2 participants