Skip to content

Commit

Permalink
feat: remove python 3.8 and add support for 3.12 and 3.13
Browse files Browse the repository at this point in the history
  • Loading branch information
nh13 committed Dec 6, 2024
1 parent ce18821 commit 78e3d97
Show file tree
Hide file tree
Showing 7 changed files with 441 additions and 377 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pythonpackage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
environment: github-action-ci
strategy:
matrix:
PYTHON_VERSION: ["3.8", "3.9", "3.10", "3.11"]
PYTHON_VERSION: ["3.9", "3.10", "3.11", "3.12", "3.13"]
steps:
- uses: actions/checkout@v2
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ${{ matrix.platform.os }}
strategy:
matrix:
python: [cp38, cp39, cp310, cp311]
python: [cp38, cp39, cp310, cp311, cp312, cp313]
platform:
- os: ubuntu-24.04
target: manylinux
Expand Down Expand Up @@ -43,7 +43,7 @@ jobs:
# Used to host cibuildwheel
- uses: actions/setup-python@v4
with:
python-version: 3.8
python-version: 3.9

- name: Install cibuildwheel
run: python -m pip install cibuildwheel==2.15.0
Expand Down
2 changes: 1 addition & 1 deletion .readthedocs.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
build:
os: ubuntu-22.04
tools:
python: "3.8"
python: "3.9"
version: 2
submodules:
include: all
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ conda activate pybedlite

[rtd-link]: http://pybedlite.readthedocs.org/en/stable

**Requires python 3.8+** (for python < 3.8, please use pybedlite <= 0.0.3)
**Requires python 3.9+**

# Getting Setup for Development Work

Expand All @@ -66,7 +66,7 @@ git clone --recurse-submodules https://github.com/fulcrumgenomics/pybedlite.git
A simple way to create an environment with the desired version of python and poetry is to use [conda][conda-link]. E.g.:

```bash
conda create -n pybedlite python=3.8 poetry
conda create -n pybedlite python=3.9 poetry
conda activate pybedlite
poetry install
```
Expand Down
800 changes: 432 additions & 368 deletions poetry.lock

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions pybedlite/tests/test_overlap_detector.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def test_construction_from_ucsc_with_strand(strand: str) -> None:
`Interval.from_ucsc()` should correctly parse UCSC position-formatted strings with strands.
"""
expected_interval = Interval("chr1", 100, 200, negative=(strand == "-"))
assert Interval.from_ucsc(f"chr1:101-200({strand})") == expected_interval
assert Interval.from_ucsc(f"chr1:101-200({strand})") == expected_interval # noqa: E231


@pytest.mark.parametrize(
Expand All @@ -223,7 +223,7 @@ def test_construction_from_ucsc_other_contigs(contig: str) -> None:
"""
`Interval.from_ucsc()` should accommodate non-human, decoy, custom, and other contig names.
"""
assert Interval.from_ucsc(f"{contig}:101-200") == Interval(contig, 100, 200)
assert Interval.from_ucsc(f"{contig}:101-200") == Interval(contig, 100, 200) # noqa: E231


def test_that_overlap_detector_allows_generic_parameterization() -> None:
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ include = ["LICENSE"]
packages = [{ include = "pybedlite" }, { include = "cgranges" }]

[tool.poetry.dependencies]
python = "^3.8.0"
python = "^3.9.0"
attrs = "^23.0.0"
sphinx = { version = "^7.0.0", optional = true }

Expand Down

0 comments on commit 78e3d97

Please sign in to comment.