feat: add probe-specific logic to Primer3 #48
Conversation
emmcauley
force-pushed
the
em_add_probe_to_task_and_input
branch
from
ed99139 to
15039d1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## em_feat_add_Probe_object #48 +/- ##
============================================================
- Coverage 97.05% 96.60% -0.45%
============================================================
Files 25 26 +1
Lines 1664 1739 +75
Branches 317 337 +20
============================================================
+ Hits 1615 1680 +65
- Misses 26 31 +5
- Partials 23 28 +5 ☔ View full report in Codecov by Sentry. |
emmcauley
changed the base branch from
em_feat_api_probe
to
em_feat_add_Probe_object
emmcauley
force-pushed
the
em_add_probe_to_task_and_input
branch
from
15039d1 to
090391b
Compare
|
|
||
|
|
||
| @dataclass(frozen=True, init=True, kw_only=True, slots=True) | ||
| class Probe(Primer, Metric["Probe"]): |
There was a problem hiding this comment.
issue Per discussion on the working group call today, we are going to add these fields directly to Primer (and maybe rename the class to Oligo or similar)
There was a problem hiding this comment.
I should have documented this because I just bumped up against why I defaulted them both to None in the first place-- if you specify the default weights for either task, then Primer3 uses those weights as part of your scoring function, and it will complain if the corresponding params are not there, because it has no delta-off-optimal to score.
| """Stores task-specific characteristics for designing an internal hybridization probe.""" | ||
|
|
||
| @classmethod | ||
| def _to_input_tags(cls, target: Span, design_region: Span) -> dict[Primer3InputTag, Any]: |
There was a problem hiding this comment.
question Does the task require either the target or design_region? How does primer3 know the range of valid locations for the probe?
| else: | ||
| if self.primer_weights is None: | ||
| object.__setattr__(self, "primer_weights", PrimerAndAmpliconWeights()) | ||
| elif self.task.requires_probe_params: |
There was a problem hiding this comment.
question Is it ever possible for a task to require both probe and primer params?
If so, you may want to consider checking both and then reporting all collected errors. But if they're mutually exclusive it's unnecessary
No description provided.