Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make OffTargetDetector.filter() generic #19

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Conversation

msto
Copy link
Collaborator

@msto msto commented Sep 18, 2024

Closes #18

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (8d332df) to head (bd04fe4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   97.35%   97.35%           
=======================================
  Files          25       25           
  Lines        1587     1589    +2     
  Branches      300      300           
=======================================
+ Hits         1545     1547    +2     
  Misses         23       23           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tfenne tfenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question ... does Python have the ability to declare a type variable as part of a function declaration? In scala we'd inline that type variable, e.g.

def filter[P <: Primer](primers: List[P]) -> List[P]

and having the type variable right there makes it easier to see what's going on.

@tfenne tfenne assigned msto and unassigned tfenne Sep 18, 2024
@clintval
Copy link
Member

@tfenne not yet but PEP 718 is tracking that language feature:

https://peps.python.org/pep-0718/

If we do get this syntax, it could arrive as soon as Py3.13 (but likely Py3.14).

https://devguide.python.org/versions/

@msto msto merged commit 02a57b1 into main Sep 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OverlapDetector.filter() should be made generic
3 participants