feat: added parameter name range for max_mixmatches_in_three_prime_re…

…gion error message
fulcrumgenomics · Jan 7, 2025 · 1a61cb0 · 1a61cb0
1 parent 73785e3
commit 1a61cb0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/prymer/offtarget/offtarget_detector.py b/prymer/offtarget/offtarget_detector.py
@@ -257,7 +257,7 @@ def __init__(
         ):
             errors.append(
                 "'max_mismatches_in_three_prime_region' must be between 0 and "
-                f"{three_prime_region_length} inclusive. "
+                f"'three_prime_region_length'={three_prime_region_length} inclusive. "
                 f"Saw {max_mismatches_in_three_prime_region}"
             )
         if max_mismatches < 0:

diff --git a/tests/offtarget/test_offtarget.py b/tests/offtarget/test_offtarget.py
@@ -362,8 +362,8 @@ class CustomPrimer(Oligo):
         (1, -1, 1, 20, 0, 0, 1, "'max_primer_pair_hits' must be greater than or equal to 0. Saw -1"),  # noqa: E501
         (1, 1, -1, 20, 0, 0, 1, "'min_primer_pair_hits' must be greater than or equal to 0. Saw -1"),  # noqa: E501
         (1, 1, 1, 0, 0, 0, 1, "'three_prime_region_length' must be greater than 0. Saw 0"),
-        (1, 1, 1, 20, -1, 0, 1, "'max_mismatches_in_three_prime_region' must be between 0 and 20 inclusive. Saw -1"),  # noqa: E501
-        (1, 1, 1, 20, 21, 0, 1, "'max_mismatches_in_three_prime_region' must be between 0 and 20 inclusive. Saw 21"),  # noqa: E501
+        (1, 1, 1, 20, -1, 0, 1, "'max_mismatches_in_three_prime_region' must be between 0 and 'three_prime_region_length'=20 inclusive. Saw -1"),  # noqa: E501
+        (1, 1, 1, 20, 21, 0, 1, "'max_mismatches_in_three_prime_region' must be between 0 and 'three_prime_region_length'=20 inclusive. Saw 21"),  # noqa: E501
         (1, 1, 1, 20, 0, -1, 1, "'max_mismatches' must be greater than or equal to 0. Saw -1"),
         (1, 1, 1, 20, 0, 0, 0, "'max_amplicon_size' must be greater than 0. Saw 0"),
     ],