Drop support for python 3.7 #98
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
+ Coverage 93.68% 93.81% +0.12%
==========================================
Files 32 33 +1
Lines 3374 3363 -11
Branches 622 617 -5
==========================================
- Hits 3161 3155 -6
+ Misses 140 137 -3
+ Partials 73 71 -2 ☔ View full report in Codecov by Sentry. |
jdidion
force-pushed
the
97/jdidion/drop-py37
branch
from
e78cdd9 to
cdffe8a
Compare
fgpyo/vcf/tests/test_builder.py
Outdated
| else random_generator.uniform(0, 1) | ||
| if value_type == VcfFieldType.FLOAT | ||
| else random_generator.choice(["Up", "Down"]) | ||
| else ( | ||
| random_generator.uniform(0, 1) | ||
| if value_type == VcfFieldType.FLOAT | ||
| else random_generator.choice(["Up", "Down"]) | ||
| ) |
There was a problem hiding this comment.
I don't understand the need for this change. The original seems more pythonic to me.
There was a problem hiding this comment.
This change was made by black after updating to a newer version.
FWIW I find the original more difficult to parse. I'm a fan of using parens to group statements (even when not strictly necessary) to improve readability.
There was a problem hiding this comment.
I can try to revert the change and see if black complains.
There was a problem hiding this comment.
I feel like a series of v1 if c1 else v2 if c2 else c3 is pretty typical for python. But the version black made isn't some unreadable abomination. If you don't care either way I'd say try to revert it. If black doesn't let you, that's that. I approved.
There was a problem hiding this comment.
Looks like the CI checks pass after reverting.
|
I'm not sure why the codecov check is failing. I deleted lots of code that was not covered by the tests, so I would have expected coverage to go up not down. |
|
I suspect it's some crazy math to do with the fraction of lines in the change that are tested? In any case, the 2nd codecov test (overall project coverage) increased. I think you've done your duty and should merge. |
|
Awesome thanks! |
No description provided.