-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a context manager for zipping FASTX files #77
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
==========================================
+ Coverage 92.88% 93.27% +0.38%
==========================================
Files 30 32 +2
Lines 3122 3331 +209
Branches 581 618 +37
==========================================
+ Hits 2900 3107 +207
- Misses 148 149 +1
- Partials 74 75 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we suggest adding this to pysam to the pysam developers?
dc8bef9
to
85ec653
Compare
What's been your approach on this for pysam vs fgpyo? I'm up for it! I have a few more PRs to make in pysam for all matter of wrong docs, bugs, and features I recently found. |
85ec653
to
d855578
Compare
I ask first, and it's nice that you can point it to here (and we can even merge it!) |
I want to add one more defensive check to make sure the class isn't used as an Iterator outside of the context manager context (which would result in a bug). Just thought of that edge case prior to merge! |
@nh13 I added one more commit and feel good with the functionality. Let me know if you'd like to re-review! |
No need for me to re review. Ship it! |
Helpful addition? Docs appear to render correctly on my local machine: