Fix type problems found by latest mypy #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TedBrookings
force-pushed
the
feature/support-updated-mypy
branch
2 times, most recently
from
e789c01 to
63c109e
Compare
nh13
requested changes
Nov 22, 2023
| return functools.partial( | ||
| lambda s: origin_type( | ||
| lambda s: list( |
There was a problem hiding this comment.
I suppose I had thought I would combine the returns in list and set, but that wouldn't be readable. Thank-you for making this clearer!
fgpyo/util/metric.py
Outdated
| @@ -226,7 +226,7 @@ def parse(cls, fields: List[str]) -> Any: | |||
| return inspect.attr_from(cls=cls, kwargs=dict(zip(header, fields)), parsers=parsers) | |||
|
|
|||
| @classmethod | |||
| def write(cls, path: Path, *values: MetricType) -> None: | |||
| def write(cls, path: Path, *values: "Metric") -> None: | |||
There was a problem hiding this comment.
Why loose this type hint? It only writes metrics of this type, so should it not be MetricType?
There was a problem hiding this comment.
Add the bound on MetricType to have Metric
| @@ -9,20 +10,19 @@ | |||
| from typing import TypeVar | |||
| from typing import Union | |||
|
|
|||
| try: | |||
| # `get_origin_type` is a method that gets the outer type (ex list in a List[str]) | |||
| # `get_arg_types` is a method that gets the inner type (ex str in a List[str]) | |||
There was a problem hiding this comment.
thank-you for adding this explanation, I forget every time.
nh13
reviewed
Nov 22, 2023
Closes #73 * Move to current latest version of pytest to avoid deprecation warning * Move to current latest version of mypy * Correct multiple problems with type and import flagged by newer mypy
TedBrookings
force-pushed
the
feature/support-updated-mypy
branch
from
63c109e to
62f2583
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
- Coverage 93.01% 92.88% -0.14%
==========================================
Files 30 30
Lines 3119 3118 -1
Branches 579 581 +2
==========================================
- Hits 2901 2896 -5
- Misses 145 148 +3
- Partials 73 74 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Newer versions of mypy reject multiple lines of fgpyo #73