Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install and test #71

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Fix install and test #71

merged 1 commit into from
Nov 7, 2023

Conversation

TedBrookings
Copy link
Contributor

  • Fix failing unit test
  • Bump pysam version to fix install problems

* Fix failing unit test
* Bump pysam version to fix install problems
@TedBrookings TedBrookings requested a review from nh13 November 7, 2023 18:13
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (28ab1e3) 92.92% compared to head (b6de0ed) 92.91%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   92.92%   92.91%   -0.01%     
==========================================
  Files          30       30              
  Lines        3052     3079      +27     
  Branches      568      572       +4     
==========================================
+ Hits         2836     2861      +25     
- Misses        144      145       +1     
- Partials       72       73       +1     
Files Coverage Δ
fgpyo/io/__init__.py 91.30% <100.00%> (+0.39%) ⬆️
fgpyo/util/tests/test_metric.py 100.00% <100.00%> (ø)
fgpyo/util/metric.py 91.00% <77.77%> (-1.31%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nh13 nh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore code cov for this one

@TedBrookings TedBrookings merged commit 273c81c into main Nov 7, 2023
5 of 6 checks passed
@TedBrookings TedBrookings deleted the tb-fix-failed-unit-test branch November 7, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants