feat: remove python 3.8 support #197
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
==========================================
+ Coverage 89.78% 89.91% +0.13%
==========================================
Files 18 18
Lines 2222 2222
Branches 493 321 -172
==========================================
+ Hits 1995 1998 +3
- Misses 149 150 +1
+ Partials 78 74 -4 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Clint Valentine <[email protected]>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| @@ -9,10 +9,10 @@ permissions: | |||
|
|
|||
| jobs: | |||
| testing: | |||
| runs-on: ubuntu-latest | |||
| runs-on: ubuntu-24.04 | |||
There was a problem hiding this comment.
WalkthroughThe pull request includes several updates across multiple files. The GitHub Actions workflow for the Python package has been modified to run on Ubuntu 24.04 and now supports Python versions 3.9, 3.10, 3.11, and 3.12, excluding Python 3.8. Similarly, the Read the Docs workflow has been updated to run on Ubuntu 24.04. The In the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
README.md (1)
40-40: Use heading instead of boldReplace bold syntax with heading for better document structure.
-**Requires python 3.9+** +## Requirements + +Requires Python 3.9+🧰 Tools
🪛 Markdownlint (0.35.0)
40-40: null
Emphasis used instead of a heading(MD036, no-emphasis-as-heading)
pyproject.toml (2)
Line range hint
31-35: Remove redundant numpy version constraint.The
python = "<3.9"constraint can be removed as the project now requires Python ≥3.9.numpy = [ {version = "^1.26.4", python = ">=3.12"}, - {version = "^1.25.2", python = ">=3.9,<3.12"}, - {version = "^1.24.4", python = "<3.9"} + {version = "^1.25.2", python = "<3.12"} ]
Line range hint
89-89: Update ruff target-version to py39.Ruff configuration should match the new minimum Python version requirement.
-target-version = "py38" +target-version = "py39"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
.github/workflows/pythonpackage.yml(1 hunks).github/workflows/readthedocs.yaml(1 hunks)README.md(2 hunks)fgpyo/util/inspect.py(2 hunks)mkdocs.yml(1 hunks)pyproject.toml(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- .github/workflows/readthedocs.yaml
🧰 Additional context used
🪛 Markdownlint (0.35.0)
README.md
40-40: null
Emphasis used instead of a heading
(MD036, no-emphasis-as-heading)
🔇 Additional comments (6)
mkdocs.yml (1)
16-17: LGTM: Documentation enhancement
Autorefs configuration improves reference resolution.
.github/workflows/pythonpackage.yml (1)
12-12: Verify dependency compatibility
Workflow updates match PR objective. Verify all dependencies support Python 3.9+.
Also applies to: 15-15
✅ Verification successful
Dependencies compatible with Python 3.9+ confirmed
Project's pyproject.toml specifies Python ">=3.9.0,<4.0" with compatible dependency versions:
- numpy: version matrix covers 3.9-3.12
- typing_extensions: properly constrained for <3.12
- All other dependencies have no version conflicts
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check dependencies in poetry.lock for Python version compatibility
poetry show | grep -E "requires.*python"
Length of output: 139
Script:
#!/bin/bash
# Check requirements.txt or setup.py for Python version requirements
fd "requirements.txt|setup.py|pyproject.toml" --type f --exec cat {}
Length of output: 2835
README.md (1)
51-51: LGTM: Version requirement update
Conda command correctly updated to Python 3.9.
pyproject.toml (1)
26-26: LGTM: Python version requirement updated correctly.
fgpyo/util/inspect.py (2)
74-76: LGTM: Type hint update is correct.
The Field[Any] type hint is more precise for Python 3.9+.
460-460: LGTM: Type ignore comment is appropriate.
The type ignore for operator is necessary for Python 3.9+ type checking.
No description provided.