fix: DataclassInstance and AttrInstance protocols #108
+10
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msto
force-pushed
the
ms_dataclass-instance
branch
from
f5b36d2 to
878b65e
Compare
msto
force-pushed
the
ms_dataclass-instance
branch
from
61c80cf to
efa55db
Compare
TedBrookings
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two minor QoL fixes
DataclassInstancetoDataclassesProtocolunnecessary, especially since it conflicted with the naming convention ofAttrInstance*Instancedefinitions to reflect the canonical definitions for each. (In particular, the implementation forAttrInstancewas bugged since__attrs_attrs__can be a tuple of attributes, not a dict)