Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add end property on SupplementaryAlignment #105

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

msto
Copy link
Contributor

@msto msto commented Apr 17, 2024

I have a context where it'd be helpful if the end were readily accessible.

@msto msto requested review from clintval, nh13 and tfenne and removed request for nh13 April 17, 2024 18:09
@msto msto force-pushed the ms_supp-aln-end branch from 8849c30 to 5fe547d Compare April 17, 2024 18:10
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.61%. Comparing base (a41a565) to head (8849c30).

❗ Current head 8849c30 differs from pull request most recent head 5fe547d. Consider uploading reports for the commit 5fe547d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   88.53%   88.61%   +0.08%     
==========================================
  Files          16       16              
  Lines        1727     1731       +4     
  Branches      321      369      +48     
==========================================
+ Hits         1529     1534       +5     
+ Misses        132      131       -1     
  Partials       66       66              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tfenne tfenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msto msto merged commit 88aebeb into main Apr 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants