Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SequenceMetadata can have name and length looked up by key #1002

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Jul 16, 2024

They will return strings for those values!

They will return strings for those values!
@nh13 nh13 requested a review from tfenne as a code owner July 16, 2024 15:33
@nh13 nh13 temporarily deployed to github-actions July 16, 2024 15:33 — with GitHub Actions Inactive
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.62%. Comparing base (c4e4bb6) to head (843a7fa).

Files Patch % Lines
...com/fulcrumgenomics/fasta/SequenceDictionary.scala 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1002   +/-   ##
=======================================
  Coverage   95.62%   95.62%           
=======================================
  Files         126      126           
  Lines        7378     7382    +4     
  Branches      490      497    +7     
=======================================
+ Hits         7055     7059    +4     
  Misses        323      323           
Flag Coverage Δ
unittests 95.62% <90.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nh13 nh13 merged commit 9a4b01d into main Jul 16, 2024
6 checks passed
@nh13 nh13 deleted the feat/sequence-dictionary branch July 16, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants