Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(net): use exclusive &mut for socket operations #841

Closed
wants to merge 1 commit into from
Closed

refactor(net): use exclusive &mut for socket operations #841

wants to merge 1 commit into from

Conversation

fujiapple852
Copy link
Owner

@fujiapple852 fujiapple852 commented Nov 29, 2023 •
edited
Loading

Closes #843

@fujiapple852 fujiapple852 mentioned this pull request Nov 29, 2023
Closed
@fujiapple852 fujiapple852 marked this pull request as draft December 13, 2023 23:01
@fujiapple852 fujiapple852 marked this pull request as ready for review December 15, 2023 13:15
@fujiapple852 fujiapple852 force-pushed the refactor-net-socket-esclusive branch from a44aa61 to ece7fc3 Compare December 15, 2023 13:17
@fujiapple852
Copy link
Owner Author

Observed error when testing on Windows (icmp, with 250ms rounds) for SendTo call:

operation on a socket could not be performed because the system lacked sufficient buffer space or because a queue was full

Unclear if related to this change.

@fujiapple852 fujiapple852 force-pushed the refactor-net-socket-esclusive branch 2 times, most recently from 6713fc6 to d33b9e4 Compare December 15, 2023 13:53
@fujiapple852 fujiapple852 marked this pull request as draft December 15, 2023 14:08
@fujiapple852 fujiapple852 marked this pull request as ready for review December 15, 2023 14:08
@fujiapple852 fujiapple852 reopened this Dec 15, 2023
@fujiapple852
Copy link
Owner Author

Superseded by #868

@fujiapple852 fujiapple852 deleted the refactor-net-socket-esclusive branch April 10, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use exclusive reference &mut for all Socket operations
1 participant
@fujiapple852