-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ESM compatibility #37
Conversation
CC @jimmycallin. |
When you tested this by changing this locally, did you rename the outputted file to |
I renamed the file as well. I also just now tried renaming it back, and then it doesn't work. So it is indeed needed. |
I'm a bit confused why this is needed for @ftrack/web-widget and not @ftrack/api so wonder if there is another underlying issue with the config that renaming to mjs hides. Will try to have a closer look later today. |
I mean, either way it's good practice to use the mjs format, and I can't see a scenario where it breaks anything. Let me know what you find either way. It's very interesting. |
@ffMathy the issue is actually a missing property |
Well, now we are switching away from Jest as well and to Vitest, just like you 😆 I think we got inspired. The VS Code Extension for Jest is a bit annoying. So I won't have time to check this out anymore unfortunately. |
Good choice :) I'll go ahead and close this PR and apply the fixes separately |
Supersedes ftrackhq/ftrack-javascript#199
Changes
Test