Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs about input object validator and scalar input coercion #457

Merged
merged 7 commits into from
Feb 14, 2024

Conversation

xperiandri
Copy link
Collaborator

No description provided.

@xperiandri xperiandri requested a review from valbers February 13, 2024 20:05
@xperiandri
Copy link
Collaborator Author

@panthus have a look too

valbers
valbers previously approved these changes Feb 13, 2024
Copy link
Collaborator

@valbers valbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to apply my suggestions or not.

Base automatically changed from normalize-optional to dev February 14, 2024 08:36
@xperiandri xperiandri dismissed valbers’s stale review February 14, 2024 08:36

The base branch was changed.

xperiandri and others added 5 commits February 14, 2024 12:37
@xperiandri xperiandri force-pushed the new-features-docs-refresh branch from e476a58 to 6f7c04a Compare February 14, 2024 08:37
@xperiandri
Copy link
Collaborator Author

@valbers lots of appreciation for fixes

@panthus
Copy link
Contributor

panthus commented Feb 14, 2024

Looks good, feel free to use my suggestions or not :)

@xperiandri
Copy link
Collaborator Author

@panthus lots of appreciation for fixes!

@xperiandri xperiandri enabled auto-merge (squash) February 14, 2024 13:23
@xperiandri xperiandri disabled auto-merge February 14, 2024 14:26
@xperiandri xperiandri merged commit 27e39fc into dev Feb 14, 2024
3 checks passed
@xperiandri xperiandri deleted the new-features-docs-refresh branch February 14, 2024 14:27
xperiandri added a commit that referenced this pull request Feb 15, 2024
…457)

* Added input object validator docs and scalar input coercion changes
* Fixed `coerceValue` description in docs

---------

Co-authored-by: Valber M. Silva de Souza <[email protected]>
Co-authored-by: panthus <[email protected]>
xperiandri added a commit that referenced this pull request Feb 15, 2024
…457)

* Added input object validator docs and scalar input coercion changes
* Fixed `coerceValue` description in docs

---------

Co-authored-by: Valber M. Silva de Souza <[email protected]>
Co-authored-by: panthus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants