Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSharp.Data.GraphQL.Server.AspNetCore #430

Merged
merged 102 commits into from
Mar 23, 2024
+5,404 −631
Merged

FSharp.Data.GraphQL.Server.AspNetCore #430

Changes from 1 commit
Commits
Show all changes
102 commits
Select commit Hold shift + click to select a range
45a7d48
ignoring the whole .vscode/ folder
valbers Mar 3, 2023
c3f1a48
introducing FSharp.Data.GraphQL.Server.AppInfrastructure
valbers Mar 4, 2023
83a9198
moving Server.AppInfrastructure near to other projs in sln
valbers Mar 5, 2023
9e88ac9
Apply suggestions from code review
valbers Mar 5, 2023
d322439
correctly calling "GetRequiredService<T>"
valbers Mar 5, 2023
bf6bd6b
using standardized namespace for chat-app sample
valbers Mar 5, 2023
c63ef2d
renamed sample chat-app to standardized proj name
valbers Mar 5, 2023
639f1e2
fixing build (related to https://github.com/dotnet/fsharp/issues/12839 )
valbers Mar 5, 2023
925873f
fixing HttpHandler: the "errors" property shouldn't be there if no errs
valbers Mar 11, 2023
6fcbf71
automatically updating chat-app/client/TestData/schema-snapshot.json
valbers Mar 11, 2023
d72500a
Apply commit suggestion
valbers Mar 11, 2023
5226c16
Apply review suggestion
valbers Mar 11, 2023
13c495e
trying to use more structured logging (and fixing code)
valbers Mar 11, 2023
f3e85cc
not calling .ToString() on objects that go into structured logging
valbers Mar 12, 2023
fdc5289
Using more concise Task.WaitAll
valbers Mar 19, 2023
34471ab
ChatAppServer -> ChatServer
valbers Mar 18, 2023
e427f55
build.fsx: intr. helper func "updateIntrospectionFile"
valbers Mar 18, 2023
ea5be34
renamed AppInfrastructure to AspNetCore
valbers Mar 19, 2023
bf672ca
removing logger.IsEnabled where it is superfluous
valbers Mar 19, 2023
c390676
Using better suited LogError overload and are shorter error message
valbers Mar 19, 2023
d8a5619
CancellationToken.None instead of new CancellationToken()
valbers Mar 19, 2023
a2b271e
Using a better suited logger.LogError overload and better phrasing
valbers Mar 19, 2023
70ba89a
chat-app sample: moved FakePersistence to own file
valbers Mar 19, 2023
d3d737f
chat-app sample: moved exception-related functions to own module
valbers Mar 19, 2023
f34167e
Server.AspNetCore: removing now superfluous "executor" parameters
valbers Mar 19, 2023
2d516b5
Server.AspNetCore: trying to improve readability by changing func sig.
valbers Mar 19, 2023
e138939
Server.AspNetCore: removed the `safe_` prefix in order to avoid confus.
valbers Mar 19, 2023
89207d0
Server.AspNetCore renaming tests to be more explicit about what's tested
valbers Mar 19, 2023
9f8cc2e
added Server.AspnetCore to github workflows
valbers Mar 19, 2023
a790882
Server.AspNetCore: trying to simplify module declaration
valbers Mar 19, 2023
b66a0f6
Server.AspNetCore: complement to my last commit (identation)
valbers Mar 19, 2023
4b2937a
Update samples/chat-app/server/Exceptions.fs
valbers Mar 19, 2023
619bae2
Authors += ", valbers"
valbers Mar 19, 2023
fefe03b
Using Task.WhenAll
valbers Mar 19, 2023
4d2a8e5
Added TODO comment related to string allocation
valbers Mar 19, 2023
ce386c8
Added TODO comment regarding string allocation
valbers Mar 19, 2023
996cfe5
Using better suited logger.LogError overload
valbers Mar 19, 2023
447af9a
Using Task.WhenAll again (instead of Async.AwaitTask + Async.RunSynch…
valbers Mar 19, 2023
7725b7b
Making code better readable
valbers Mar 19, 2023
a05eb43
Revert "Using Task.WhenAll again (instead of Async.AwaitTask + Async.…
valbers Mar 19, 2023
a1ef59e
Revert "Using Task.WhenAll"
valbers Mar 19, 2023
28c386a
Extracted the target frameworks into a single file
xperiandri Feb 9, 2024
7128a68
Suppressed the warning about the `WebClient` in the `Build` project
xperiandri Feb 9, 2024
83f1734
Added constants for F# optional type names
Oct 18, 2023
b37b993
Fixed wrong condition on checking if dictionary is mutable
Oct 18, 2023
bb6c21e
Implemented converting `Option` and `ValueOption` returned from scala…
Oct 18, 2023
b1e180b
Implemented check that ValueOption returned from scalar coercion is a…
Oct 18, 2023
fe8712c
Added value object tests
xperiandri Feb 10, 2024
96dbd31
Adding HttpContext as parameter to root factory
valbers Feb 14, 2024
1422288
Merge branch 'dev' into introduce-graphql-transport-ws
valbers Feb 14, 2024
9fe5f2e
Adjusting ...Server.AspNetCore's branch code to latest `dev` stage
valbers Feb 19, 2024
a616a9f
Replacing locally maintained "Rop" with FsToolkit.ErrorHandling in...
valbers Feb 24, 2024
c28251b
Complement to my last commit (removed commented out code)
valbers Feb 24, 2024
9e4f942
Also in GraphQLWebsocketMiddleware using FsToolkit.ErrorHandling...
valbers Feb 25, 2024
566c848
new HttpHandler: fixing error handling on "applyPlanExecutionResult"
valbers Feb 26, 2024
00c1a29
Extracted the target frameworks into a single file
xperiandri Feb 9, 2024
073f980
Merge branch 'dev' into introduce-graphql-transport-ws
valbers Feb 26, 2024
ce0d437
.Server.AspNetCore: adding either package ref or proj. ref. according...
valbers Feb 26, 2024
18a71d5
.Server.AspNetCore: added targets "pack" and "push" for this new project
valbers Feb 26, 2024
b95ebf2
.Server.AspNetCore: added some documentation to functions.
valbers Feb 26, 2024
f6dd828
.Server.AspNetCore: correctly parsing variable value to JsonElement
valbers Feb 28, 2024
7216ece
chat-app sample: adapted code to new error handling and added proj to ..
valbers Feb 28, 2024
e5891f1
Update README.md
valbers Mar 5, 2024
89601ac
.Samples.ChatApp: removed superfluous `Label` attr. from ItemGroup
valbers Mar 5, 2024
65c7c52
.Samples.ChatApp: launchSettings.json: commandNames according to temp…
valbers Mar 5, 2024
3af6a11
Samples.StarWarsApi.fsproj : sorting Project References by name
valbers Mar 5, 2024
1552bd4
Using interpolated strings instead of sprintf at many places
valbers Mar 5, 2024
5c51714
.Samples.ChatApp: better name for logger
valbers Mar 5, 2024
51851ea
.Server.AspNetCore: formatted code with Fantomas
valbers Mar 6, 2024
318901d
Removed superfluous JsonOptions configuration
valbers Mar 6, 2024
390e893
samples: removing KestrelServerOptions.AllowSynchronousIO <- true...
valbers Mar 6, 2024
d6f9611
samples/chat-app: undoing wrong changes to launchSetting.json
valbers Mar 6, 2024
9b29037
.IntegrationTests.Server: removed some now superfluous settings
valbers Mar 6, 2024
017cdd7
.Server.AspNetCore/README.md: updated the sample snippet to...
valbers Mar 6, 2024
afa2b7a
Added ability to get idented `JsonSerializerOptions`
xperiandri Mar 10, 2024
dfdb263
Moved chat-app near to starwars-api
xperiandri Mar 10, 2024
7c2ad5f
Aligned StarWars API to ChatApp
xperiandri Mar 10, 2024
2888db6
Aligned code style
xperiandri Mar 10, 2024
b43c29d
Consolidated common logic in `FSharp.Data.GraphQL.Server.AspNetCore` …
xperiandri Mar 10, 2024
f482a98
Added GraphQL playgounds to chat-app
xperiandri Mar 10, 2024
41e5ec3
Fixed constant like values naming style
xperiandri Mar 10, 2024
379c354
Fixed tests
xperiandri Mar 10, 2024
fc50670
Fixed `FSharp.Data.GraphQL.Server.AspNetCore` tests
xperiandri Mar 10, 2024
e65e943
Fixed integration tests
xperiandri Mar 10, 2024
1281c27
Added missing `FSharp.Data.GraphQL.Server.AspNetCore` package referen…
xperiandri Mar 10, 2024
a3ce3c6
Set appropriate logging level
xperiandri Mar 11, 2024
8e4943d
Moved Giraffe request handlers out of the GraphQL handler
xperiandri Mar 11, 2024
ee93b7f
Fixed integration tests
xperiandri Mar 11, 2024
a0c464d
Implemented request cancellation passing inside GraphQL execution
xperiandri Mar 11, 2024
a6ee3e2
Set GraphQL request body error logging to the warning level and moved…
xperiandri Mar 17, 2024
38fed3c
Migrated to ValueOption, IOptions<> and simplified WebSocket handling…
xperiandri Mar 17, 2024
0cfd55c
InvalidMessageException -> InvalidWebsocketMessageException
valbers Mar 17, 2024
cd3b1ce
.AspNetCore: using static logger serializer options and fixed typo:
valbers Mar 17, 2024
c566724
Revert ".AspNetCore: using static logger serializer options and fixed…
valbers Mar 20, 2024
418aa7a
.AspNetCore: fixed typo: Idented -> Indented
valbers Mar 20, 2024
c9951c3
.WebsocketMiddleware: logging with logger instead of `printfn`
valbers Mar 20, 2024
855d5a7
.WebsocketMiddleware: logging it when subscriber already exists
valbers Mar 20, 2024
5dde6e9
Aligned error and logging messages, simplified WebSockets logging code
xperiandri Mar 21, 2024
bf6ab98
...WebsocketMiddleware.fs: improved warning logging
valbers Mar 21, 2024
4b16c87
.WebsocketMiddleware: better WS message deserialization exception handl.
valbers Mar 20, 2024
e7cfeff
chat-app: naming ObjectDef variables according to implicit convention
valbers Mar 21, 2024
f5f5294
Made error response static and fixed capital in error
xperiandri Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/FSharp.Data.GraphQL.Server.AppInfrastructure/GraphQLWebsocketMiddleware.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ type GraphQLWebSocketMiddleware<'Root>(next : RequestDelegate, applicationLifeti
task {
if not (socket.State = WebSocketState.Open) then
if logger.IsEnabled(LogLevel.Trace) then
logger.LogTrace(sprintf "ignoring message to be sent via socket, since its state is not 'Open', but '%A'" socket.State)
logger.LogTrace("Ignoring message to be sent via socket, since its state is not 'Open', but '{state}'" socket.State)
else
let! serializedMessage = message |> serializeServerMessage jsonSerializerOptions
let segment =
Expand Down