Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.2.3 PR Fixes #436

Merged
merged 2 commits into from
Sep 30, 2020
Merged

V3.2.3 PR Fixes #436

merged 2 commits into from
Sep 30, 2020

Conversation

paresh-accolite
Copy link

@kapil2704
Copy link
Contributor

This needs testing before merge as we are using Lodash as some places & some of the functions may hamper previously encountered issue of 'events'. So will review & update this soon.

@kapil2704
Copy link
Contributor

I can observe that 'initialized' event is not working this PR, so im not merging this.

Here is the screenshot from Master branch
Screenshot from 2020-09-30 10-55-17

Here is the scrrenshot from this PR
Screenshot from 2020-09-30 10-54-23

public titleOptions: Object = {
placeholderText: 'Edit Your Content Here!',
charCounterCount: false,
// toolbarInline: true,
events: {
"initialized": () => {
console.log('initialized');
},
"contentChanged": () => {
console.log("content changed");
},
"focus": () => {
console.log('focus')
},
"blur": () => {
console.log('blur')
}
}
}

@paresh-accolite
Copy link
Author

@kapil2704 yes i have found the issue , it was regarding registration of initialize event , I have fixed it .

Please find the working sample :

iangular

@kapil2704
Copy link
Contributor

Thanks @paresh-accolite Working fine now, im merging this.

@kapil2704 kapil2704 merged commit 48d13a5 into froala:v3.2.3 Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants