Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/return parsed unknown actions #9

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Fix/return parsed unknown actions #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a82654
fix: parse action should return unknown actions
RainBoltz Dec 12, 2024
7820866
test: add test case for unknown action
RainBoltz Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,9 @@ function parseActionViaOrdersCell(orders: Cell): ActionReadable[] {
for (const index of actions.keys()) {
const actionCell = actions.get(index);
if (!actionCell) {
actionsArray.push({
type: "UNKNOWN",
});
continue;
}
const actionSlice = actionCell.beginParse();
Expand Down Expand Up @@ -330,6 +333,9 @@ function parseActionViaOrdersCell(orders: Cell): ActionReadable[] {
const body = message.body;

if (!to || typeof value !== "bigint") {
actionsArray.push({
type: "UNKNOWN",
});
continue;
}

Expand Down Expand Up @@ -369,15 +375,32 @@ function parseActionViaOrdersCell(orders: Cell): ActionReadable[] {
recipient: destReal,
jettonWallet: to,
});
} else {
actionsArray.push({
type: "UNKNOWN",
});
continue;
}
} else {
// TODO: may be an external message out
actionsArray.push({
type: "UNKNOWN",
});
continue;
}
} else {
// TODO: this is an unknown action type
actionsArray.push({
type: "UNKNOWN",
});
continue;
}
} else {
// TODO: this is an broken action
actionsArray.push({
type: "UNKNOWN",
});
continue;
}
}
return actionsArray;
Expand Down
7 changes: 6 additions & 1 deletion src/interfaces/ton.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,15 @@ interface SendJettonActionReadable {
jettonWallet: Address;
}

interface UnknownActionReadable {
type: "UNKNOWN";
}

type ActionReadable =
| UpdateConfigActionReadable
| SendTonActionReadable
| SendJettonActionReadable;
| SendJettonActionReadable
| UnknownActionReadable;

export type {
MultisigConfig,
Expand Down
12 changes: 12 additions & 0 deletions tests/parser.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ describe("parser module", () => {
"te6cckEBBAEAlQABpnUJf10AABl+3WWlwQAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAABnNx5pA4+tvnaMAYUTyEX9d/zovaadS2uhCBq3kydtzCDgCw9FAQEB0QIBCvE4HlsDAwBiYgBM2gS0UWkjIjXlqEy+0JWpHYQNkvdQfLcHQCXMUAHgWYgIAAAAAAAAAAAAAAAAABaC4q8=",
transferJettonSucceedHex:
"b5ee9c720101050100f40001a675097f5d000000000000000000000000000000000000000000000000000000000000000000000000000000070000671f785601394cdb6e9b8806a121a67bfd87060dae964adb2df2d832a52e0de7847f5ba68e010101d102010af1381e5b0303016862002ddf224969471566ad31ab85d96c4362bf5161a1bb439422a3a555f3ca98f8b02017d78400000000000000000000000000010400b20f8a7ea5000000000000000080de0b6b3a7640000801d616c2fc969e59676ee6d0039f12422394e6408813c14460ca6e235b42bd02d5001bd3ff9dcc3cbaddb3682bbeb75dff9773d73e29f2ed02b7f9ac41323019eaf88202",
transferMintJettonSucceedHex:
"b5ee9c724101040100c8000101d101010af1381e5b010201cb22000a84948273202b222549f4d6e53bc6ad7d0ce635397434e60debf863b9c61364a02faf080000000000000000000000000000642b7d070000000000000000801a5f99fa0d456e15ce7de153efe3398a27a458324c8d01d3a1bb4c41361301958805f5e1010300a1178d4519000000000000000010a8002a125209cc80ac889527d35b94ef1ab5f43398d4e5d0d39837afe18ee7184d93003c748f6bbc113d19cf7c325e95bab6f67c3feb5fdf6edec00a9befe81637df3d818631ac6b"
};

it("should parse action as send ton", () => {
Expand Down Expand Up @@ -39,4 +41,14 @@ describe("parser module", () => {
expect(transferJettonSucceedHexResult).toHaveLength(1);
expect(transferJettonSucceedHexResult[0].type).toBe("SEND_JETTON");
});

it("should parse action as unknown (send mint jetton)", () => {
const transferMintJettonSucceedHexResult = parseActionViaOrdersCell(
Cell.fromHex(messageBody.transferMintJettonSucceedHex)
.beginParse()
.loadRef(),
);
expect(transferMintJettonSucceedHexResult).toHaveLength(1);
expect(transferMintJettonSucceedHexResult[0].type).toBe("UNKNOWN");
});
});
Loading